Restore cider--display-interactive-eval-result overlays for compilation errors
#3492
Conversation
…tion errors Fixes #3487
| (when-let ((conn (with-current-buffer buffer | ||
| (cider-current-repl)))) | ||
| (when (cider-nrepl-op-supported-p "analyze-last-stacktrace" conn) | ||
| (when-let* ((result (nrepl-send-sync-request (thread-last (map-merge 'list |
There was a problem hiding this comment.
There may be up to 2 analyze-last-stacktrace requests during the same interaction (one async in defun cider-default-err-op-handler, one sync in here).
About 1mo ago I had tried doing this sort of thing in just 1 async call, but was overly complex.
For avoiding any unnecessary costs, we can introduce some caching, cider-nrepl side. The cache would have a size of 1 (since one normally is only interested in analyzing the last exception - older exceptions are uninteresting / unlikely to be re-queried)
There was a problem hiding this comment.
I checked this out and while our stacktrace analysis isn't blazing-fast, runtimes in the 20-40ms range don't seem worth caching.
cider-eval.el
Outdated
| @@ -774,6 +775,19 @@ REPL buffer. This is controlled via | |||
| (cider--make-fringe-overlay (point))) | |||
| (scan-error nil))))) | |||
|
|
|||
| (defun cider--error-phase-of-latest-exception (buffer) | |||
There was a problem hiding this comment.
Probably last is a better term than latest for this. Or most-recent.
|
The changes look good to me. |
Fixes #3487
cider-interactive-eval-handler: Check if the given exception's phase is ignored, and if so, display the overlay.*cider-error*(not both, not none)I've tested this out locally for all cases, and it works nicely.
No changelog is needed.
Cheers - V